Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve memory allocation when generating expression identifier #115

Merged
merged 3 commits into from
Jan 9, 2023
Merged

Improve memory allocation when generating expression identifier #115

merged 3 commits into from
Jan 9, 2023

Conversation

adria0
Copy link
Member

@adria0 adria0 commented Jan 2, 2023 •
edited
Loading

For the the implementation of the EVM ChallengeAPI, implement the following improvements:

  • Expression::identifier() remove string memory reallocation

  • Adds a transpose method to turn Value<Result<_>> into Result<Value<_>>

  • Implements PartialOrd for Value<F>

- Implements PartialOrd for Value<F>
551c782 
- Adds a `transpose` method to turn `Value<Result<_>>` into
  `Result<Value<_>>`
- `Expression::identifier()` remove string memory reallocation
@adria0 adria0 marked this pull request as ready for review January 2, 2023 17:49
@adria0 adria0 requested a review from han0110 January 2, 2023 17:50
@adria0 adria0 mentioned this pull request Jan 2, 2023
Merged
han0110
han0110 approved these changes Jan 9, 2023
View reviewed changes
Copy link

@han0110 han0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

halo2_proofs/src/circuit/value.rs Outdated Show resolved Hide resolved
@adria0 adria0 changed the title Helpers & improvements to implement Challenge API in EVM cicuit Improve memory allocation when generating expression identifier Jan 9, 2023
@adria0 adria0 merged commit 0af4611 into main Jan 9, 2023
@adria0 adria0 mentioned this pull request Jan 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@han0110 han0110 han0110 approved these changes

@ed255 ed255 ed255 left review comments

@CPerezz CPerezz CPerezz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adria0 @han0110 @ed255 @CPerezz