fix: address comments from @duguorong009 and @CPerezz

privacy-scaling-explorations · Mar 21, 2024 · e3acbd7 · e3acbd7
1 parent 6edce3e
commit e3acbd7
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 4 deletions.
diff --git a/halo2_frontend/src/circuit.rs b/halo2_frontend/src/circuit.rs
@@ -134,11 +134,9 @@ pub struct WitnessCollection<'a, F: Field> {
     current_phase: sealed::Phase,
     advice_column_phase: &'a Vec<sealed::Phase>,
     advice: Vec<Vec<Assigned<F>>>,
-    // pub unblinded_advice: HashSet<usize>,
     challenges: &'a HashMap<usize, F>,
     instances: &'a [&'a [F]],
     usable_rows: RangeTo<usize>,
-    _marker: std::marker::PhantomData<F>,
 }
 
 impl<'a, F: Field> Assignment<F> for WitnessCollection<'a, F> {
@@ -337,7 +335,6 @@ impl<'a, F: Field, ConcreteCircuit: Circuit<F>> WitnessCalculator<'a, F, Concret
             // number of blinding factors and an extra row for use in the
             // permutation argument.
             usable_rows: ..self.unusable_rows_start,
-            _marker: std::marker::PhantomData,
         };
 
         // Synthesize the circuit to obtain the witness and other information.

diff --git a/halo2_frontend/src/plonk/circuit.rs b/halo2_frontend/src/plonk/circuit.rs
@@ -37,7 +37,6 @@ impl ColumnType for Advice {
             index: None,
             column_index: index,
             rotation: at,
-            // phase: sealed::Phase(self.phase),
         })
     }
 }