Make clippy happy

privacy-scaling-explorations · Jun 18, 2024 · 51e132e · 51e132e
1 parent 1e8ddc3
commit 51e132e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 9 deletions.
diff --git a/halo2_frontend/src/dev.rs b/halo2_frontend/src/dev.rs
@@ -1529,10 +1529,7 @@ mod tests {
                     let s_ltable = cells.query_selector(s_ltable);
 
                     // If q is enabled, a must be in the table.
-                    vec![
-                        (q.clone() * a.clone(), s_ltable.clone() * table),
-                        (q * a, s_ltable * advice_table),
-                    ]
+                    vec![(q * a, s_ltable * table), (q * a, s_ltable * advice_table)]
                 });
 
                 FaultyCircuitConfig {
@@ -1607,7 +1604,7 @@ mod tests {
                     let table = cells.query_instance(table, Rotation::cur());
 
                     // If q is enabled, a must be in the table.
-                    vec![(q.clone() * a.clone(), table), (q * a, advice_table)]
+                    vec![(q * a, table), (q * a, advice_table)]
                 });
 
                 FaultyCircuitConfig {
@@ -1750,8 +1747,8 @@ mod tests {
                     // If q is enabled, a must be in the table.
                     // If `s_ltable` is enabled, the value of `advice_table` & `table` is used as lookup table.
                     vec![
-                        (q.clone() * a.clone(), table * s_ltable.clone()),
-                        (q.clone() * a, advice_table * s_ltable.clone()),
+                        (q * a, table * s_ltable),
+                        (q * a, advice_table * s_ltable),
                         (q, s_ltable),
                     ]
                 });

diff --git a/halo2_proofs/examples/circuit-layout.rs b/halo2_proofs/examples/circuit-layout.rs
@@ -243,7 +243,7 @@ impl<F: FieldFront> Circuit<F> for MyCircuit<F> {
             let sc = meta.query_fixed(sc, Rotation::cur());
             let sm = meta.query_fixed(sm, Rotation::cur());
 
-            vec![a.clone() * sa + b.clone() * sb + a * b * sm - (c * sc) + sf * (d * e)]
+            vec![a * sa + b * sb + a * b * sm - (c * sc) + sf * (d * e)]
         });
 
         PlonkConfig {

diff --git a/halo2_proofs/examples/proof-size.rs b/halo2_proofs/examples/proof-size.rs
@@ -39,7 +39,7 @@ impl Circuit<Fp> for TestCircuit {
 
         meta.lookup("lookup", |meta| {
             let selector = meta.query_selector(config.selector);
-            let not_selector = Expression::Constant(Fp::ONE) - selector.clone();
+            let not_selector = Expression::Constant(Fp::ONE) - selector;
             let advice = meta.query_advice(config.advice, Rotation::cur());
             vec![(selector * advice + not_selector, config.table)]
         });