Parallel Nova PoC #11
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/r1cs_folding_generalization R1CS folding verification
…/construct_parallel_tree Add parallel prover with tree construction
…/r1cs_folding_generalization Finish the prover merge code
…st_fix Fixes a bug with the tests
Co-authored-by: aleph_v <20227705+aleph-v@users.noreply.github.com>
…e_space_of_witness Fix namespace of the witness
# Conflicts: # src/parallel_circuit.rs # src/parallel_prover.rs
…ing-explorations/Nova into violet/bug/test_fix
…st_fix Fixes many bugs
…/dummy_test_of_parallel_prover Add dummy test for parallel prover
hero78119
pushed a commit
to hero78119/SuperNova
that referenced
this pull request
Jan 3, 2024
* refactor: Remove R1CS struct to direct commitment_key calls - Removed the `R1CS` struct and its associated types from `r1cs.rs` as well as its public use in `lib.rs`. - Updated the program's `commitment_key` and `commitment_key_size` functions to require explicit Group type parameter, instead of being derived from the `R1CS` struct. - Adapted functions to the removal of `R1CS` struct, using `commitment_key` directly. * refactor: Simplify NIFS struct and remove PhantomData usage - Simplified the NIFS struct in `nifs.rs` file by removing extraneous elements. * refactor: Refactor ipa_pc.rs to use InnerProductArgument directly - Removed `EvaluationArgument` struct from `ipa_pc.rs` file, replacing it with direct usage of `InnerProductArgument`. - Updated `EvaluationEngineTrait` type declarations to accommodate the change. - Reworked `prove` and `verify` methods to work directly with `InnerProductArgument`. - Made `InnerProductArgument` visibility public. * refactor: Refactor PoseidonROCircuit struct trait bound - Trait bound changed from `PrimeField + PrimeFieldBits` to `PrimeField` in `poseidon.rs`. * refactor: mutualize macro for secp/bn256 cycles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This long-lived branch contains all the work done for ParaNova PoC in Vietnam. Opening PR for awareness and to show current diff. It needs to be rebased and tied up a bit before it makes sense to integrate it fully.
The existing main branch has been updated to be kept up to date with Nova upstream. This will make it easier to have a independent work streams of HyperNova and ParaNova.
Long-lived branches:
cc @CPerezz @arnaucube