Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HyperNova] Make tests generic w.r.t. curve and field #34

Closed
oskarth opened this issue Jul 14, 2023 · 2 comments
Closed

[HyperNova] Make tests generic w.r.t. curve and field #34

oskarth opened this issue Jul 14, 2023 · 2 comments
Assignees

Comments

@oskarth
Copy link
Collaborator

oskarth commented Jul 14, 2023

Problem

We want tests to be generic, so we can test against different curves etc more easily.

We also don't want to introduce "regressions" w.r.t. code style for HyperNova work.

Context

From upstream PR review:

There were recent PRs (e.g., microsoft#171, microsoft#165) to make tests generic over the curves. I wonder if it makes sense to continue that approach to allow library users to switch curves and still run these tests more easily.

Originally posted by @srinathsetty in microsoft#175 (comment)

Acceptance criteria

All newly introduced tests (w.r.t. upstream) are generic w.r.t. F or G.

@oskarth
Copy link
Collaborator Author

oskarth commented Jul 14, 2023

Partially done here #31

Once approach seems OK can do for rest of tests

@oskarth
Copy link
Collaborator Author

oskarth commented Jul 20, 2023

Done above.

@oskarth oskarth closed this as completed Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant