Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attributesJSON doesn't respect attributes filter #192

Open
valignatev opened this issue Apr 26, 2023 · 1 comment
Open

attributesJSON doesn't respect attributes filter #192

valignatev opened this issue Apr 26, 2023 · 1 comment

Comments

@valignatev
Copy link

valignatev commented Apr 26, 2023

Hey, thanks for this project! Gutenberg is awful, but your plugin makes working with it bearable :)

I've noticed that attributesJSON don't seem to encode correct set of attributes if I modify one of them through graphql_gutenberg_block_attributes_fields filter. After I do this, attributes contain filtered value for the attributed that I'm interested in, but attributesJSON contain the old one, pre-filtered.

graphql_gutenberg_block_attributes somewhat does half of the job, but it would be very nice if it were after getting source blocks, not before. Because my particular case is filling up an attribute if the block doesn't have it

@valignatev
Copy link
Author

valignatev commented Apr 26, 2023

#124 would have allowed to fix this issue indirectly

@valignatev valignatev changed the title attributesJSON don't respect attributes filter attributesJSON doesn't respect attributes filter Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant