Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gap to progressbar with multiple sections #4995

Merged
merged 5 commits into from
Sep 20, 2024

Conversation

lukasoppermann
Copy link
Contributor

This bug was mentioned in slack and is apparent when looking at the docs.

Expected
When a progressbar has multiple sections, a 2px gap is shown between them.

Current behavior
When a progressbar has multiple sections, a no gap is shown between them. making them sometimes very hard to distinguish.

without gap

Changelog

  • added a 2opx gap when the Progressbar component has children.
Before After
before without gap after with gap
  • added sections control to the playground story to allow users to check the difference.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Sep 20, 2024

🦋 Changeset detected

Latest commit: 4283297

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 20, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.46 KB (+0.1% 🔺)
packages/react/dist/browser.umd.js 97.68 KB (-0.12% 🔽)

Copy link
Contributor

@TylerJDev TylerJDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment to fix the gap property not being applied, but otherwise looks good!

packages/react/src/ProgressBar/ProgressBar.tsx Outdated Show resolved Hide resolved
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see 2 suggestions, other than that. All good!

Approving in advance

lukasoppermann and others added 2 commits September 20, 2024 16:03
Co-authored-by: Tyler Jones <tylerjdev@github.com>
Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com>
Merged via the queue into main with commit 8a1ee22 Sep 20, 2024
32 checks passed
@lukasoppermann lukasoppermann deleted the @lukasoppermann/progressbar branch September 20, 2024 15:16
@primer primer bot mentioned this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants