Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover: Remove the caret #4978

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Popover: Remove the caret #4978

wants to merge 6 commits into from

Conversation

TylerJDev
Copy link
Contributor

@TylerJDev TylerJDev commented Sep 17, 2024

Part of https://github.com/github/primer/issues/3432

Removes the caret in Popover.

Changelog

Removed

  • Removes caret prop and associated styles from Popover component

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Sep 17, 2024

🦋 Changeset detected

Latest commit: 8f80d76

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 17, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.12 KB (-0.36% 🔽)
packages/react/dist/browser.umd.js 97.46 KB (-0.23% 🔽)

@TylerJDev TylerJDev changed the title Remove the caret Popover: Remove the caret Sep 18, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-4978 September 18, 2024 13:31 Inactive
@TylerJDev TylerJDev mentioned this pull request Sep 20, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant