Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(CounterLabel): update to use CSS Modules behind flag #4965

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

refactor(CounterLabel): update to use CSS Modules behind flag #4965

wants to merge 7 commits into from
+197 −113

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Sep 13, 2024 •
edited by jonrohan
Loading

Closes https://github.com/github/primer/issues/3918

Changelog

New

Changed

  • Update CounterLabel to use a styled version under the hood instead of box to make it easier to migrate
  • Update CounterLabel to use CSS Modules
  • Refactor e2e tests for CounterLabel
  • Add additional story for CounterLabel

Removed

Rollout strategy

  • Minor release

@joshblack joshblack requested a review from a team as a code owner September 13, 2024 20:46
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 13, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 30ca350

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Sep 13, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-4965 September 13, 2024 20:48 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 13, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.94 KB (+0.11% 🔺)
packages/react/dist/browser.umd.js 98.23 KB (+0.17% 🔺)

@primer primer deleted a comment from primer-integration bot Sep 17, 2024
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/342701

@github-actions github-actions bot temporarily deployed to storybook-preview-4965 September 20, 2024 20:59 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4965 September 20, 2024 21:02 Inactive
joshblack and others added 2 commits September 20, 2024 18:38
@joshblack @langermank
Update packages/react/src/CounterLabel/CounterLabel.module.css
e97007a 
Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com>
@joshblack @langermank
Update packages/react/src/CounterLabel/CounterLabel.module.css
30ca350 
Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langermank langermank langermank left review comments

@jonrohan jonrohan jonrohan approved these changes

Assignees
No one assigned
Labels
staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshblack @jonrohan @langermank