Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StateLabel should have the issueClosed colour updated #2140

Closed
anleac opened this issue Jun 23, 2022 · 0 comments · Fixed by #2171
Closed

StateLabel should have the issueClosed colour updated #2140

anleac opened this issue Jun 23, 2022 · 0 comments · Fixed by #2171

Comments

@anleac
Copy link
Contributor

anleac commented Jun 23, 2022

Describe the bug
Component at hand: https://primer.style/react/StateLabel

Closed issues on GitHub have a new colour for the background of their state label, which is no longer red.

New:

image

State label still shows:

image

Create a StateLabel component with the state being issueClosed, you will witness a state with a red background.

Expected behavior
The background colour should be set to: rgb(137, 87, 229) - I believe this is the same as the merged colour used currently for the state pullMerged

Screenshots
Attached above.

Desktop (please complete the following information):
All browsers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants