Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No props typings for TextInput #1948

Closed
jclem opened this issue Mar 10, 2022 · 1 comment · Fixed by #1959
Closed

No props typings for TextInput #1948

jclem opened this issue Mar 10, 2022 · 1 comment · Fixed by #1959
Assignees
@mperrotti @colebemis
Labels
bug Something isn't working react

Comments

@jclem
Copy link
Contributor

jclem commented Mar 10, 2022

Describe the bug

The TextInput component has no props other than key and ref:

CleanShot 2022-03-10 at 12 18 59@2x

Note that the type of onKeyDown is inferred as true because the effective types for TextInput appear to be essentially any & React.RefAttributes & React.Attributes (meaning any along with key and ref).

To Reproduce

Edit TextInput components anywhere, such as in the TextInput.test.tsx file.
@jclem jclem changed the title No props typing for TextInput No props typings for TextInput Mar 10, 2022
@colebemis colebemis added react bug Something isn't working labels Mar 10, 2022
@colebemis
Copy link
Contributor

Add to our project board. Thank you!

@rezrah rezrah mentioned this issue Mar 14, 2022
Closed
@colebemis colebemis assigned colebemis and unassigned colebemis Mar 14, 2022
@colebemis colebemis mentioned this issue Mar 14, 2022
Merged
@mperrotti mperrotti self-assigned this Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mperrotti mperrotti

@colebemis colebemis

Labels
bug Something isn't working react
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix TextInput types primer/react
3 participants
@jclem @mperrotti @colebemis