-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing generated prop documentation for TextInput #1419
Comments
🕵️ This is what I have till now: The props don't show up because they aren't generated by They did have trouble with Trying to make the smallest reproducible bug, it seems like docgen isn't able to parse this specific line. Still looking for the fix. |
Excellent detective work, @siddharthkp 🕵️ ✨ Seems like the solution to this issue is either simplify the way we right types or change how we generate prop documentation (maybe we could use I also think this calls for a more general discussion about how we want to handle prop documentation (i.e. can it be generated or is manually maintaining it okay?). Can you create a discussion about that in github/primer or primer/react when you have a chance? |
Started a discussion to log exploration work: #1492 |
This doesn't seem to be relevant anymore as TextInput and doc issues have been fixed. Please re-open if required. |
Problem
The
Props
component that we use to generate prop documentation doesn't work with theTextInput
component:Tasks
TextInput
Notes
The
Props
component was added in this PR and is implemented withreact-docgen-typescript
. I'm guessing there are other components that don't work with theProps
component as well.The text was updated successfully, but these errors were encountered: