Deprecate utility components #1316
Conversation
🦋 Changeset detectedLatest commit: 1965269 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-components/ApXwFqbohTKh7yDJKffaW8xLef4z |
VanAnderson
force-pushed
the
VanAnderson/deprecate-utility-components
branch
from
88cc754
to
5d76285
Compare
There was a problem hiding this comment.
Excellent work, @VanAnderson! Thanks for going above and beyond by writing a codemod for these changes.
This looks good to go. But let's wait to merge this until #1315 is merged.
| ` | ||
| import {Box} from '@primer/components' | ||
| export default () => ( | ||
| <Box display="flex"> |
There was a problem hiding this comment.
Can we test that other props are preserved? Example:
- <Flex flexDirection="column">
+ <Box display="flex" flexDirection="column">
.changeset/metal-swans-allow.md
Outdated
| "@primer/components": minor | ||
| --- | ||
|
|
||
| Deprecate utility components. |
There was a problem hiding this comment.
It might be helpful for consumers if we listed all the deprecated components explicitly here.
There was a problem hiding this comment.
In addition to a list of deprecated components, let's also include instructions on how to run the codemod here.
Co-authored-by: Cole Bemis <colebemis@github.com>
Co-authored-by: Cole Bemis <colebemis@github.com>
Co-authored-by: Cole Bemis <colebemis@github.com>
Co-authored-by: Cole Bemis <colebemis@github.com>
…:primer/components into VanAnderson/deprecate-utility-components
Deprecate Utility Components in favor of Box.
Closes https://github.com/github/primer/issues/223
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.