Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: extract constants and types #399

Merged
merged 2 commits into from
Jun 23, 2022
Merged

fix: extract constants and types #399

merged 2 commits into from
Jun 23, 2022

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Jun 21, 2022

close #398

@Shinigami92 Shinigami92 added the type: enhancement Functionality that enhances existing features label Jun 23, 2022
@Shinigami92
Copy link
Member

Nice work, nothing I need to comment
I just can merge it 🙂 👍

@Shinigami92 Shinigami92 merged commit 06d03ee into prettier:main Jun 23, 2022
@JounQin JounQin deleted the fix/path branch June 23, 2022 13:06
@JounQin
Copy link
Member Author

JounQin commented Jun 23, 2022

It’s so kind of you, that’s my pleasure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees
No one assigned
Labels
type: enhancement Functionality that enhances existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid use . or circular dependency in src/options files
2 participants
@JounQin @Shinigami92