Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve conversion of tags to literals #134

Merged
merged 1 commit into from
Oct 5, 2020
Merged

Improve conversion of tags to literals #134

merged 1 commit into from
Oct 5, 2020

Conversation

lehni
Copy link
Collaborator

@lehni lehni commented Oct 4, 2020

Closes #133

lehni
lehni commented Oct 4, 2020
View reviewed changes
src/printer.ts Show resolved Hide resolved
@lehni
Copy link
Collaborator Author

lehni commented Oct 4, 2020

@Shinigami92 this change should actually speed things up a little, since replace() is now only called on the tag string, not the full content in this.result

Shinigami92
Shinigami92 requested changes Oct 5, 2020
View reviewed changes
src/printer.ts Outdated Show resolved Hide resolved
@lehni lehni requested a review from Shinigami92 October 5, 2020 08:50
@Shinigami92 Shinigami92 added the type: enhancement Functionality that enhances existing features label Oct 5, 2020
@Shinigami92 Shinigami92 merged commit 0c86747 into master Oct 5, 2020
@lehni lehni deleted the issue-133 branch October 5, 2020 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees

@lehni lehni

Labels
type: enhancement Functionality that enhances existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: conversion of literals can replace the wrong content
2 participants
@lehni @Shinigami92