Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SameSite=none value to WordPress cookies for LTI launches #1919

Closed
SteelWagstaff opened this issue Apr 10, 2020 · 1 comment
Closed

Add SameSite=none value to WordPress cookies for LTI launches #1919

SteelWagstaff opened this issue Apr 10, 2020 · 1 comment
Assignees
Labels
Medium - 5 Planning Poker T-Shirt Size security Pull requests that address a security vulnerability upstream issue that needs an upstream fix

Comments

@SteelWagstaff
Copy link
Member

SteelWagstaff commented Apr 10, 2020

When users launch Pressbooks within their LMS via LTI, they load the page securely via iFrame inside another application (the LMS). Chrome has recently tightened their policies around SameSite cookies, and require a SameSite=None and Secure values in order for these pages to display properly. Chrome's default value is "lax" rather than "strict" or "none". WordPress does not natively allow it's authentication cookies to be filtered with SameSite values. There's a WP ticket that talks about support for SameSite attributes in PHP 7.3 and discusses the possible use of a plugin and edits to the wpconfig.php file: https://core.trac.wordpress.org/ticket/37000#comment:26. Another plugin https://github.com/MikhailRoot/samesite-cookie-manager/blob/master/samesite-cookie-manager.php may be similarly promising. We should investigate further to see if we can do this safely and responsibly for networks which use our LTI plugin.

@SteelWagstaff SteelWagstaff added security Pull requests that address a security vulnerability upstream issue that needs an upstream fix Medium - 5 Planning Poker T-Shirt Size labels Apr 10, 2020
@ricardopressbooks
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Medium - 5 Planning Poker T-Shirt Size security Pull requests that address a security vulnerability upstream issue that needs an upstream fix
Projects
None yet
Development

No branches or pull requests

2 participants