Add option to force Unix EOL on YAML export via the CLI #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I believe this is ready for review! |
Vitor-Avila
reviewed
Sep 24, 2024
Vitor-Avila
reviewed
Sep 24, 2024
Vitor-Avila
reviewed
Sep 24, 2024
|
thank you so much for the contribution, @kevmk04! 🙏 This is super cool. 🙌 |
|
@Vitor-Avila Should be all good now with your PR comments. |
Vitor-Avila
reviewed
Sep 26, 2024
Vitor-Avila
reviewed
Sep 26, 2024
Vitor-Avila
reviewed
Sep 26, 2024
Vitor-Avila
reviewed
Sep 26, 2024
Vitor-Avila
reviewed
Sep 26, 2024
Vitor-Avila
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Thank you so much for working on this, @kevmk04! I left some minor comments around the tests. We should be good to merge this once they're addressed. 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds an optional argument to the CLI export commands to force Unix EOLs for the exported files. This is intended to address issues when exporting into Windows environments where we have multiple developers using different OS.