Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dbt-sync): Migrate legacy endpoints to fix virtual dataset creation #232
fix(dbt-sync): Migrate legacy endpoints to fix virtual dataset creation #232
Changes from 3 commits
f6f3254
a2e840e
b152a2b
d95ea15
2c06a4f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about doing the validation first, and then change line 567 to
if "sql" not in kwargs or not_legacy
so that we would only have a singlereturn
, but then I realized most commonly the integration syncs physical datasets, and this change would always executevalidate_key_in_resource_schema
which is another API request. With that in mind, I decided to have a second block for this, so that we only call this other endpoint if needed (trying to not increase the dataset sync duration).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed this was set to
True
here even tough the default state isFalse
, so I updated only for consistency but it doesn't really change the result. It should be totally fine to revert it toTrue
if we want to.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought about only including
is_managed_externally
to the update payloads in case--disallow-edits
flag was used, but then I realized that if a user wanted to trigger a new sync without this flag to set it toFalse
, that wouldn't work. So I only added this warning which in addition to the error faced for legacy instances should be pretty straightforward (the error would actually happens even if--disallow-edits
isn't included).