fix: Removing the certification key in case certification is null #215
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few fixes/improvements to the dataset certification flow:
certification
is set tonull
via the dbt model definition, before we were settingcertification: null
in the dataset, which wouldn't show the certification pop up, but it would still include the dataset when filtering forcertified: yes
. With these changes, in casecertification
is set tonull
in the model definition, thecertification
key won't be included in the dataset'sextra
field.certification
local variable tocertification_info
to better distinguish from the function argument. Also changed its content to a dictionary to only include the key pair in theextra
definition in case it contains an actual value.