fix: Removing the certification key in case certification is null #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betodealmeida
approved these changes
Jun 5, 2023
Comment on lines
+89
to
+95
| certification_info = { | ||
| "certification": ( | ||
| model_kwargs.get("extra", {}).pop("certification") | ||
| if "certification" in model_kwargs.get("extra", {}) | ||
| else certification or {"details": "This table is produced by dbt"} | ||
| ), | ||
| } |
There was a problem hiding this comment.
Just a nit, but sometimes it's cleaner to use a try/except:
try:
certification_info = model_kwargs["extra"]["certification"]
except KeyError:
certification_info = certification or DEFAULT_CERTIFICATION(and we'd define DEFAULT_CERTIFICATION)
There was a problem hiding this comment.
That's a very good feedback, @betodealmeida! I'm going to merge this PR for now to solve the issue in main, and address this in a future PR.
There was a problem hiding this comment.
Handled this here: #221
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few fixes/improvements to the dataset certification flow:
certificationis set tonullvia the dbt model definition, before we were settingcertification: nullin the dataset, which wouldn't show the certification pop up, but it would still include the dataset when filtering forcertified: yes. With these changes, in casecertificationis set tonullin the model definition, thecertificationkey won't be included in the dataset'sextrafield.certificationlocal variable tocertification_infoto better distinguish from the function argument. Also changed its content to a dictionary to only include the key pair in theextradefinition in case it contains an actual value.