fix(superset): get_database
#211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betodealmeida
force-pushed
the
fix_get_database
branch
from
24ffa69
to
bdc9523
Compare
betodealmeida
force-pushed
the
fix_get_database
branch
from
bdc9523
to
3dd76d0
Compare
zephyring
approved these changes
May 30, 2023
| response = self.session.get(url) | ||
| validate_response(response) | ||
|
|
||
| resource = response.json()["result"] |
There was a problem hiding this comment.
it will be nice to have a schema for the return object
There was a problem hiding this comment.
I am not familiar with the above 2 endpoints but another option is to introduce a new method for the connection endpoint.
The API client should be as dumb as possible otherwise changes from the API could easily break this client again.
There was a problem hiding this comment.
Good point, I have a TODO in that file to add them. It's not super trivial because the schema depends on the version of Superset running.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a CVE, some of the information available in
api/v1/database/$idwas moved toapi/v1/database/$id/connection. This PR updates the Superset client to try both endpoints.Added a test covering the case.