Fix MetricSchema loading
#159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughhhh
reviewed
Dec 5, 2022
| @@ -110,7 +110,7 @@ def get_metrics_for_model( | |||
| ) | |||
| break | |||
|
|
|||
| if model["unique_id"] == parents.pop(): | |||
| if parents == {model["unique_id"]}: | |||
There was a problem hiding this comment.
why don't you want to use the .pop ?
There was a problem hiding this comment.
pop modified the object inplace, and even though we don't need it later I thought the new approach represents better what I want to test (I want to make sure that parents is a set with a single element and that element is equal to model['unique_id']).
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #157
We were dropping the new metric fields when loading the metrics. I added them to
MetricSchema, and also changed the loading so that we don't drop new fields in the future.