-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement List SCIM groups #143
Conversation
List groups
List groups
Hey @betodealmeida, I finally managed to finish creating all the tests. Would appreciate your review here! :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
I realized though that the pre-commit tests are not running on CI. Can you run them manually for now? You need to run:
pip install pre-commit
pre-commit install
pre-commit run --all-files
This will reformat your files and check types as well.
So, I performed these steps, but the
I tried to access https://gitlab.com/pycqa/flake8 and I face a 404, so I think that's the issue. For now, I manually updated the link on After that, I faced below error:
Seems to be related to the This is the test result:
|
Ah, I read about the change from GitLab to GitHub. Let me fix that. |
Thank you! I'm going over the required changes for the pre-commit checks! |
Updating repo
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
Adding a new feature to the CLI, that list SCIM groups and their membership. The feature allows to print the results directly to the terminal (useful for quick troubleshooting small teams), and also use
--save-report=yaml
or--save-report=csv
to save the results in a file. The file name would be{TeamSlug}__user_group_membership.{FileExtension}
.