Implement List SCIM groups #143

Vitor-Avila · 2022-11-06T21:42:28Z

Adding a new feature to the CLI, that list SCIM groups and their membership. The feature allows to print the results directly to the terminal (useful for quick troubleshooting small teams), and also use --save-report=yaml or --save-report=csv to save the results in a file. The file name would be {TeamSlug}__user_group_membership.{FileExtension}.

List groups

Vitor-Avila · 2022-11-15T12:18:41Z

Hey @betodealmeida,

I finally managed to finish creating all the tests. Would appreciate your review here! :D

betodealmeida

This looks great!

I realized though that the pre-commit tests are not running on CI. Can you run them manually for now? You need to run:

pip install pre-commit
pre-commit install
pre-commit run --all-files

This will reformat your files and check types as well.

src/preset_cli/cli/main.py

README.rst

src/preset_cli/api/clients/preset.py

Vitor-Avila · 2022-11-16T02:54:25Z

This looks great!

I realized though that the pre-commit tests are not running on CI. Can you run them manually for now? You need to run:
pip install pre-commit
pre-commit install
pre-commit run --all-files
This will reformat your files and check types as well.

So, I performed these steps, but the pre-commit was failing:

fatal: repository 'https://gitlab.com/pycqa/flake8.git/' not found

I tried to access https://gitlab.com/pycqa/flake8 and I face a 404, so I think that's the issue. For now, I manually updated the link on .pre-commit-config.yaml file to https://github.com/pycqa/flake8.

After that, I faced below error:

Traceback (most recent call last):
  File "/Users/vitoravila/.cache/pre-commit/repoivqubj_g/py_env-python3/bin/black", line 8, in <module>
    sys.exit(patched_main())
  File "/Users/vitoravila/.cache/pre-commit/repoivqubj_g/py_env-python3/lib/python3.9/site-packages/black/__init__.py", line 6606, in patched_main
    patch_click()
  File "/Users/vitoravila/.cache/pre-commit/repoivqubj_g/py_env-python3/lib/python3.9/site-packages/black/__init__.py", line 6595, in patch_click
    from click import _unicodefun  # type: ignore
ImportError: cannot import name '_unicodefun' from 'click' (/Users/vitoravila/.cache/pre-commit/repoivqubj_g/py_env-python3/lib/python3.9/site-packages/click/__init__.py)

Seems to be related to the black version - manually changed the rev from rev: 20.8b1 to rev: 22.10.0.

This is the test result:

(local-cli) ➜  backend-sdk git:(list-groups) ✗ pre-commit run --all-files
Check for added large files..............................................Passed
Check python ast.........................................................Passed
Check JSON...............................................................Passed
Check for merge conflicts................................................Passed
Check Xml............................................(no files to check)Skipped
Check Yaml...............................................................Passed
Debug Statements (Python)................................................Passed
Fix End of Files.........................................................Passed
Fix requirements.txt.....................................................Passed
Mixed line ending........................................................Passed
isort....................................................................Passed
black....................................................................Failed
- hook id: black
- files were modified by this hook

reformatted tests/cli/main_test.py

All done! ✨ 🍰 ✨
1 file reformatted, 67 files left unchanged.

flake8...................................................................Passed
mypy.....................................................................Failed
- hook id: mypy
- exit code: 1

tests/api/clients/superset_test.py:1878: error: _Yaml? has no attribute "encode"
Found 1 error in 1 file (checked 68 source files)

Add trailing commas......................................................Failed
- hook id: add-trailing-comma
- exit code: 1
- files were modified by this hook

Rewriting tests/cli/main_test.py

pycln....................................................................Passed
pylint...................................................................Failed
- hook id: pylint
- exit code: 12

************* Module /Users/vitoravila/code/cli-mod/backend-sdk/.pylintrc
.pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'duplicate-code
use-implicit-booleaness-not-comparison
fixme' (unknown-option-value)
.pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'duplicate-code
use-implicit-booleaness-not-comparison
fixme' (unknown-option-value)

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)

************* Module /Users/vitoravila/code/cli-mod/backend-sdk/.pylintrc
.pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'duplicate-code
use-implicit-booleaness-not-comparison
fixme' (unknown-option-value)
.pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'duplicate-code
use-implicit-booleaness-not-comparison
fixme' (unknown-option-value)

-------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 9.94/10, +0.06)

************* Module /Users/vitoravila/code/cli-mod/backend-sdk/.pylintrc
.pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'duplicate-code
use-implicit-booleaness-not-comparison
fixme' (unknown-option-value)
.pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'duplicate-code
use-implicit-booleaness-not-comparison
fixme' (unknown-option-value)

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)

************* Module /Users/vitoravila/code/cli-mod/backend-sdk/.pylintrc
.pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'duplicate-code
use-implicit-booleaness-not-comparison
fixme' (unknown-option-value)
.pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'duplicate-code
use-implicit-booleaness-not-comparison
fixme' (unknown-option-value)

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)

************* Module /Users/vitoravila/code/cli-mod/backend-sdk/.pylintrc
.pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'duplicate-code
use-implicit-booleaness-not-comparison
fixme' (unknown-option-value)
.pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'duplicate-code
use-implicit-booleaness-not-comparison
fixme' (unknown-option-value)
************* Module preset_cli.auth.lib
src/preset_cli/auth/lib.py:23:15: W3101: Missing timeout argument for method 'requests.post' can cause your program to hang indefinitely (missing-timeout)

------------------------------------------------------------------
Your code has been rated at 9.73/10 (previous run: 9.73/10, +0.00)

************* Module /Users/vitoravila/code/cli-mod/backend-sdk/.pylintrc
.pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'duplicate-code
use-implicit-booleaness-not-comparison
fixme' (unknown-option-value)
.pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'duplicate-code
use-implicit-booleaness-not-comparison
fixme' (unknown-option-value)

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)

************* Module /Users/vitoravila/code/cli-mod/backend-sdk/.pylintrc
.pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'duplicate-code
use-implicit-booleaness-not-comparison
fixme' (unknown-option-value)
.pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'duplicate-code
use-implicit-booleaness-not-comparison
fixme' (unknown-option-value)
************* Module src.preset_cli.auth.main
src/preset_cli/auth/main.py:19:0: R0022: Useless option value for 'disable', 'no-self-use' was moved to an optional extension, see https://pylint.pycqa.org/en/latest/whatsnew/2/2.14/summary.html#removed-checkers. (useless-option-value)

------------------------------------------------------------------
Your code has been rated at 9.96/10 (previous run: 9.96/10, +0.00)

************* Module /Users/vitoravila/code/cli-mod/backend-sdk/.pylintrc
.pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'duplicate-code
use-implicit-booleaness-not-comparison
fixme' (unknown-option-value)
.pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'duplicate-code
use-implicit-booleaness-not-comparison
fixme' (unknown-option-value)
************* Module preset_cli.cli.main
src/preset_cli/cli/main.py:337:0: R0914: Too many local variables (16/15) (too-many-locals)
src/preset_cli/cli/main.py:360:4: R1702: Too many nested blocks (7/5) (too-many-nested-blocks)
src/preset_cli/cli/main.py:360:4: R1702: Too many nested blocks (6/5) (too-many-nested-blocks)
src/preset_cli/cli/main.py:337:0: R0912: Too many branches (18/12) (too-many-branches)

------------------------------------------------------------------
Your code has been rated at 9.93/10 (previous run: 9.92/10, +0.02)

************* Module /Users/vitoravila/code/cli-mod/backend-sdk/.pylintrc
.pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'duplicate-code
use-implicit-booleaness-not-comparison
fixme' (unknown-option-value)
.pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'duplicate-code
use-implicit-booleaness-not-comparison
fixme' (unknown-option-value)

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)

************* Module /Users/vitoravila/code/cli-mod/backend-sdk/.pylintrc
.pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'duplicate-code
use-implicit-booleaness-not-comparison
fixme' (unknown-option-value)
.pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'duplicate-code
use-implicit-booleaness-not-comparison
fixme' (unknown-option-value)

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)

************* Module /Users/vitoravila/code/cli-mod/backend-sdk/.pylintrc
.pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'duplicate-code
use-implicit-booleaness-not-comparison
fixme' (unknown-option-value)
.pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'duplicate-code
use-implicit-booleaness-not-comparison
fixme' (unknown-option-value)
************* Module preset_cli.auth.password
src/preset_cli/auth/password.py:27:0: R0022: Useless option value for 'disable', 'no-self-use' was moved to an optional extension, see https://pylint.pycqa.org/en/latest/whatsnew/2/2.14/summary.html#removed-checkers. (useless-option-value)

------------------------------------------------------------------
Your code has been rated at 9.96/10 (previous run: 9.96/10, +0.00)

************* Module /Users/vitoravila/code/cli-mod/backend-sdk/.pylintrc
.pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'duplicate-code
use-implicit-booleaness-not-comparison
fixme' (unknown-option-value)
.pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'duplicate-code
use-implicit-booleaness-not-comparison
fixme' (unknown-option-value)

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)

************* Module /Users/vitoravila/code/cli-mod/backend-sdk/.pylintrc
.pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'duplicate-code
use-implicit-booleaness-not-comparison
fixme' (unknown-option-value)
.pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'duplicate-code
use-implicit-booleaness-not-comparison
fixme' (unknown-option-value)

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)

************* Module /Users/vitoravila/code/cli-mod/backend-sdk/.pylintrc
.pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'duplicate-code
use-implicit-booleaness-not-comparison
fixme' (unknown-option-value)
.pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'duplicate-code
use-implicit-booleaness-not-comparison
fixme' (unknown-option-value)

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)

betodealmeida · 2022-11-16T22:39:03Z

Ah, I read about the change from GitLab to GitHub. Let me fix that.

Vitor-Avila · 2022-11-16T23:31:45Z

Thank you! I'm going over the required changes for the pre-commit checks!

Updating repo

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

betodealmeida

This looks great!

Vitor-Avila and others added 13 commits November 6, 2022 18:32

Implementing the ability to list SCIM groups and their membership

1ec1ce4

Removing un-unsed import

8fb7625

Merge pull request #1 from Vitor-Avila/list-groups

0730f32

List groups

Add remaining tests

7ff0509

Better exception handling

c8be195

trying to fix the tests

edf6258

Update main_test.py

8b658a0

Update python-package-daily.yml

a58519b

Merge pull request #2 from Vitor-Avila/list-groups

e03b5fb

List groups

Update main.py

021bd56

a

6b3a128

Update main.py

221d6ab

Update main_test.py

7945fd8

betodealmeida requested changes Nov 15, 2022

View reviewed changes

Vitor-Avila and others added 12 commits November 16, 2022 23:59

Merge pull request #3 from preset-io/main

a950508

Updating repo

fixing tests

44ebc41

test

8f38d4f

Adding more test coverage

07699b6

finished adding test coverage:

ee23b7b

Update src/preset_cli/cli/main.py

00618c9

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

Update src/preset_cli/cli/main.py

92d4404

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

Update README.rst

eaa1522

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

Update src/preset_cli/api/clients/preset.py

a4d6840

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

Improving code

f4a7df1

This was incorrectly modified to quickly test something

6529d17

Updating readme

3e554db

Fixing tests

63fe07d

Vitor-Avila requested a review from betodealmeida November 18, 2022 20:31

Merge branch 'main' into list-groups

267b4e3

betodealmeida approved these changes Nov 30, 2022

View reviewed changes

betodealmeida merged commit 7d44b4d into preset-io:main Nov 30, 2022

Vitor-Avila deleted the list-groups branch November 30, 2022 12:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement List SCIM groups #143

Implement List SCIM groups #143

Vitor-Avila commented Nov 6, 2022

Vitor-Avila commented Nov 15, 2022

betodealmeida left a comment

Vitor-Avila commented Nov 16, 2022

betodealmeida commented Nov 16, 2022

Vitor-Avila commented Nov 16, 2022

betodealmeida left a comment

Implement List SCIM groups #143

Implement List SCIM groups #143

Conversation

Vitor-Avila commented Nov 6, 2022

Vitor-Avila commented Nov 15, 2022

betodealmeida left a comment

Choose a reason for hiding this comment

Vitor-Avila commented Nov 16, 2022

betodealmeida commented Nov 16, 2022

Vitor-Avila commented Nov 16, 2022

betodealmeida left a comment

Choose a reason for hiding this comment