fix (native): no password prompt on db update #140
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing an asset sync, if a database YAML file has a masked password (eg,
postgresql://user:XXXXXXXXXX@host:5432/dbname
) and the database already exists, don't prompt users for the password. We can simply pass the masked password and Superset will do the right thing.Also fix a dataset bug I found when exporting the
examples
database. For some reason theparams
attribute in the dataset is a string:Even though it should be an object:
https://github.com/apache/superset/blob/d3f930a5575f03bc5f4f468b8bf37e834bf2aa4d/superset/datasets/commands/export.py#L61