-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Switching URL to api.app.preset.io #127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this, @craig-rueda !
Weird that the tests are reporting missing coverage:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I'm just confused about the early return
when we run preset-cli auth
.
if ctx.invoked_subcommand == "auth": | ||
# The user is trying to auth themselves, so skip anything auth-related | ||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this the credentials will never be stored (line 155) when the user runs preset-cli auth
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def auth()
is invoked after this method, so that's where they will be stored. Then, the user would call something else, like superset
, which would fetch the JWT, etc
Switches manager baseUrl from
manage.app.preset.io
over toapi.app.preset.io