feat(dbt): sync column label

preset-io · Mar 30, 2023 · a419429 · a419429
1 parent 8a3a8b3
commit a419429
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/preset_cli/cli/superset/sync/dbt/datasets.py b/src/preset_cli/cli/superset/sync/dbt/datasets.py
@@ -159,6 +159,7 @@ def sync_datasets(  # pylint: disable=too-many-locals, too-many-branches, too-ma
                 name = column["column_name"]
                 if name in columns:
                     column["description"] = columns[name].get("description", "")
+                    column["label"] = columns[name].get("label", "")
 
                 # remove columns that are not part of the update payload
                 for key in ("changed_on", "created_on", "type_generic"):

diff --git a/tests/cli/superset/sync/dbt/datasets_test.py b/tests/cli/superset/sync/dbt/datasets_test.py
@@ -45,7 +45,7 @@
             "meta": {},
             "name": "messages_channels",
             "unique_id": "model.superset_examples.messages_channels",
-            "columns": {"id": {"description": "Primary key"}},
+            "columns": {"id": {"description": "Primary key", "label": "some label"}},
         },
     ),
 ]
@@ -115,6 +115,7 @@ def test_sync_datasets_new(mocker: MockerFixture) -> None:
                     {
                         "column_name": "id",
                         "description": "Primary key",
+                        "label": "some label",
                         "is_dttm": False,
                     },
                     {
@@ -205,6 +206,7 @@ def test_sync_datasets_with_alias(mocker: MockerFixture) -> None:
                     {
                         "column_name": "id",
                         "description": "Primary key",
+                        "label": "some label",
                         "is_dttm": False,
                     },
                     {
@@ -264,6 +266,7 @@ def test_sync_datasets_no_metrics(mocker: MockerFixture) -> None:
                     {
                         "column_name": "id",
                         "description": "Primary key",
+                        "label": "some label",
                         "is_dttm": False,
                     },
                 ],
@@ -356,6 +359,7 @@ def test_sync_datasets_existing(mocker: MockerFixture) -> None:
                     {
                         "column_name": "id",
                         "description": "Primary key",
+                        "label": "some label",
                         "is_dttm": False,
                     },
                 ],
@@ -443,6 +447,7 @@ def test_sync_datasets_external_url(mocker: MockerFixture) -> None:
                     {
                         "column_name": "id",
                         "description": "Primary key",
+                        "label": "some label",
                         "is_dttm": False,
                     },
                 ],