Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🙏 not writeable strided for vectorized #128

Merged
merged 1 commit into from
Jun 5, 2024
Merged

🙏 not writeable strided for vectorized #128

merged 1 commit into from
Jun 5, 2024

Conversation

jvdd
Copy link
Member

@jvdd jvdd commented Jun 4, 2024 •
edited
Loading

Needs perhaps some more elaborate testing

@jvdd jvdd requested a review from jonasvdd June 4, 2024 12:17
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jun 4, 2024

CodSpeed Performance Report

Merging #128 will improve performances by 45.49%

Comparing not_writeable_vect (9f84bf2) with main (e12e550)

Summary

⚡ 2 improvements
✅ 379 untouched benchmarks

Benchmarks breakdown

Benchmark main not_writeable_vect Change
⚡ test_single_series_feature_collection_multiple_descriptors[2] 243.3 ms 167.2 ms +45.49%
⚡ test_single_series_feature_collection_multiple_descriptors[4] 83.7 ms 70.2 ms +19.16%

jonasvdd
jonasvdd approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@jonasvdd jonasvdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jvdd jvdd merged commit 4dada32 into main Jun 5, 2024
20 checks passed
@jvdd jvdd deleted the not_writeable_vect branch August 24, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasvdd jonasvdd jonasvdd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jvdd @jonasvdd