Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep options.debounceRendering #1315

Merged
merged 3 commits into from
Mar 4, 2019
Merged

Keep options.debounceRendering #1315

merged 3 commits into from
Mar 4, 2019

Conversation

developit
Copy link
Member

Preserve the old options.debounceRendering instead of renaming it to Component.debounce

@coveralls
Copy link

coveralls commented Mar 4, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling b421460 on keep-options-debouncerendering into 29c92e5 on master.

@developit developit requested review from marvinhagemeister and andrewiggins and removed request for marvinhagemeister March 4, 2019 23:15
marvinhagemeister
marvinhagemeister approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! One less breaking change 🎉

@developit developit merged commit e7a9ce2 into master Mar 4, 2019
@developit developit deleted the keep-options-debouncerendering branch March 4, 2019 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@andrewiggins andrewiggins Awaiting requested review from andrewiggins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@developit @coveralls @marvinhagemeister