fix: check whether oldDom is present in the DOM (#4318)

* leverage isConnected * expect ts error
preactjs · Apr 5, 2024 · 7fbf03f · 7fbf03f
1 parent 3a1b19a
commit 7fbf03f
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/diff/children.js b/src/diff/children.js
@@ -116,7 +116,8 @@ export function diffChildren(
 			childVNode._flags & INSERT_VNODE ||
 			oldVNode._children === childVNode._children
 		) {
-			if (!newDom && oldVNode._dom == oldDom) {
+			// @ts-expect-error olDom should be present on a DOM node
+			if (oldDom && !oldDom.isConnected) {
 				oldDom = getDomSibling(oldVNode);
 			}
 			oldDom = insert(childVNode, oldDom, parentDom);