Add test for signals

src/diff/index.js

@@ -501,13 +501,11 @@ function diffElementNodes(
 		} else if (typeof newChildren === 'string') {
 			if (newChildren !== oldProps.children) {
 				// Unmount any previous children
-				if (oldVNode._children) {
-					while ((i = oldVNode._children.pop())) {
-						// Setting textContent on the dom element will unmount all DOM nodes
-						// of the previous children, so we don't need to remove DOM in this
-						// call to unmount
-						unmount(i, oldVNode, true);
-					}
+				while (oldVNode._children && (i = oldVNode._children.pop())) {
+					// Setting textContent on the dom element will unmount all DOM nodes
+					// of the previous children, so we don't need to remove DOM in this
+					// call to unmount
+					unmount(i, oldVNode, true);
 				}
 
 				// @ts-expect-error

test/browser/components.test.js

@@ -1,4 +1,4 @@
-import { createElement, render, Component, Fragment } from 'preact';
+import { createElement, render, Component, Fragment, createRef } from 'preact';
 import { setupRerender } from 'preact/test-utils';
 import {
 	setupScratch,
@@ -2078,6 +2078,17 @@ describe('Components', () => {
 			expect(parentDom1.base).to.equalNode(scratch.firstChild);
 		});
 
+		it('should set c.base for a single text-node child', () => {
+			let ref = createRef();
+			const SignalValue = props => {
+				return props.text;
+			};
+			render(<SignalValue ref={ref} text="hello world" />, scratch);
+			console.log(ref.current);
+			expect(ref.current.base.nodeType).to.equal(3);
+			expect(ref.current.base.data).to.equal('hello world');
+		});
+
 		it('should not update sibling c.base if child component changes DOM nodes', () => {
 			let s1 = {},
 				s2 = {},