Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing license info #11

Open
cglong opened this issue Mar 8, 2018 · 3 comments
Open

Missing license info #11

cglong opened this issue Mar 8, 2018 · 3 comments

Comments

@cglong
Copy link

cglong commented Mar 8, 2018

I see in Cargo.toml that license is set to "MIT" but I don't see a LICENSE file anywhere in the repo or headers on any of the source/example files. Would it be possible to get these added?

@pravic
Copy link
Owner

pravic commented Mar 8, 2018

Perhaps. Is it necessary? I see that also there is a way to just mention it in the README, but again, it's not obligatory (because of "may include").

I really don't want to add unnecessary files or to pollute sources. But I could include that phrase in README if license field isn't enough.

@cglong
Copy link
Author

cglong commented Mar 8, 2018

IANAL, but reading the license, it sounds like the text itself needs to be physically present somewhere in the repo (which makes sense to me because you are basically enumerating the rights you are granting).

I understand your reasoning behind wanting to minimize the number of files. Personally, I would opt for a LICENSE file, but it sounds like including the whole body of text in the README should work as well.

Sidenote: I would also personally include the license copy in the header of each file; that way, if a consumer chooses to only use a subset of your repo (e.g. one of the examples), it's clear who owns the copyright and under what license it's being made available.

@stevemk14ebr
Copy link

stevemk14ebr commented Sep 10, 2021

hello, licensing your code would be very welcome, i'd like to use it :) If you just create the file LICENSE via github online it will make a little license selector where you can just click a template

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants