Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: IndexIter optimizations. #19

Open
prataprc opened this issue Dec 11, 2019 · 1 comment
Open

core: IndexIter optimizations. #19

prataprc opened this issue Dec 11, 2019 · 1 comment

Comments

@prataprc
Copy link
Owner

Using trait object gives convenience of abstraction. But performance can be an issue. Once such design choice is core::IndexIter trait object.

Validate the performance penalty in using IndexIter and if possible replace it with concrete types/traits.

@prataprc
Copy link
Owner Author

A good first candidate is core::CommitIterator, which returns IndexIter in its present form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant