Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a scanning option to skip the initial input enumeration #46

Open
bradlarsen opened this issue Apr 19, 2023 · 0 comments
Open

Add a scanning option to skip the initial input enumeration #46

bradlarsen opened this issue Apr 19, 2023 · 0 comments
Labels
performance Related to runtime performance

Comments

@bradlarsen
Copy link
Collaborator

noseyparker scan currently always does an initial enumeration of the filesystem inputs. The only user-facing reason for doing this currently is to show a progress bar when scanning. This is detrimental in a couple cases:

  1. When running without a terminal (like with output directed to a file), the progress bars are not shown, and the initial filesystem enumeration is not useful.
  2. When scanning large inputs from slow filesystems (like old magnetic disks or Docker bind mounts on macOS), simply enumerating the inputs can be as slow as actually scanning everything!

It would be useful to automatically avoid enumeration when progress bars are not displayed. It would also be beneficial to have an explicit control to avoid enumeration, to help in cases of slow I/O.

@bradlarsen bradlarsen added the performance Related to runtime performance label Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Related to runtime performance
Projects
None yet
Development

No branches or pull requests

1 participant