Why highlight references and echo diagnostics only in normal mode?

[mitinarseny]

• Why not to implement g:lsp_highlight_references and g:lsp_highlight_references_insert boolean variables and add autocommands for insert mode as well?
  

  vim-lsp/autoload/lsp.vim

  Line 208 in 5dd94c6

  autocmd CursorMoved * call s:on_cursor_moved()

• And why clean reference highlighting on InsertEnter?
  

  vim-lsp/autoload/lsp.vim

  Line 210 in 5dd94c6

  autocmd BufWinEnter,BufWinLeave,InsertEnter * call lsp#ui#vim#references#clean_references()

• With g:lsp_diagnostics_float_cursor enabled unmapping from Mapping to lsp_float_opened results in loosing references highlighting #787 causing error: no such mapping:

autocmd User lsp_float_closed call lsp#ui#vim#references#highlight(v:false)
      \ | nunmap <buffer> <Esc>

I'm just asking before submitting PR as it can be done for some reason...

P.S.: Why augroup is empty here?)

vim-lsp/autoload/lsp/ui/vim/output.vim

Lines 27 to 29 in 9fa593a

	augroup lsp_float_preview_close
	augroup end
	autocmd! lsp_float_preview_close CursorMoved,CursorMovedI,VimResized *

[prabirshrestha]

Feel free to send a PR to support it in non normal mode.

[mitinarseny]

I am just wondering if these lines have any particular reasons to exist? Were there any hidden reasons why not to support it in non-normal mode as these lines prevent it?

[prabirshrestha]

There is no particular reason for it.

We just need to make sure it is debounce properly so every cursor move doesn't cause flushing which causes diff computation which is heavy. Some users may not like to see errors as they type while some would prefer it but if debounce is handled it shouldn't be an issue.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.