-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typehints (label) - mypy #451
Comments
Hi! I didn't know about I'll try to solve all (I pushed a new commit a few hours ago) in the next few days. |
I think that static analysis does not work very well. In the case you provided, I've reviewed dozens of
However, within baseimage.draw the "if area is None" is already addressed; thus, these pygame-menu/pygame_menu/baseimage.py Lines 814 to 815 in 39a6e92
For these reasons, I will close this issue for now. Anyone with typing improvements can create as many PRs as they want. Thanks! |
Hello, there!
I was running
mypy
to check for typehints (spring cleaning) and it flagged me the labels (with .translate)-> no issues with buttons and images.
Out of curiosity I tried to run
mypy
on this file:https://github.com/ppizarror/pygame-menu/blob/master/pygame_menu/examples/other/widget_positioning.py
the output with pygame_menu 4.3.8:
that's the exact output I get on my repository.
The text was updated successfully, but these errors were encountered: