Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: #517 error #857

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

WIP: #517 error #857

wants to merge 3 commits into from

Conversation

gylove1994
Copy link

Related: #517

Copy link
Owner

@ppetzold ppetzold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you use the existing entities or enhance the existing entities to showcase the error?

that way this branch can directly be used to implement the bug fix as well

@gylove1994
Copy link
Author

could you use the existing entities or enhance the existing entities to showcase the error?

that way this branch can directly be used to implement the bug fix as well

Seem using the existing entities is hard to reproduce this error. So I removed some redundant code to make it more clear.

@gylove1994 gylove1994 marked this pull request as ready for review January 17, 2024 01:42
@gylove1994 gylove1994 marked this pull request as draft January 17, 2024 01:42
@gylove1994
Copy link
Author

any progress?

@Helveg
Copy link
Collaborator

Helveg commented Mar 3, 2024

Hi @gylove1994 ! If you change this test to use the existing entities I can have a look for you :) Why exactly is it easier to use these new entities? Maybe if I understand that, I can find a good middle ground :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants