Separate server and client passwords optionally #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levkk
changed the title
levkk
changed the title
magec
reviewed
Apr 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
Add
server_usernameandserver_passwordto theuserconfig to allow to connect with different username and password to Postgres. I'm adding this because I'd like to create two pools using the same Postgres username and password, one in session mode and the other in transaction mode.This is optional and default behavior is the same as before, to use the client username and password to connect.
Bug fixes
Maybe fix the
Cmessage from the client not being supported. I'm not entirely sure howCloseworks, and if the client expects a reply immediately or afterS.Add missing
requirements.txtto the toml config docs generator.