A couple things #397
Merged
A couple things #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magec
reviewed
Apr 11, 2023
| @@ -45,7 +45,7 @@ log_client_connections = false | |||
| log_client_disconnections = false | |||
|
|
|||
| # When set to true, PgCat reloads configs if it detects a change in the config file. | |||
There was a problem hiding this comment.
Comment is outdated, maybe specifying also unit? (milliseconds)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo fmtinclient.rsandserver.rserrors.rsto make error reporting more straight forward.autoreloadfrom boolean toOption<i64>to actually set autoreload interval. This is a breaking config change.application_nameon the server after it's set to idle; this helps debugging who used the server last, which is very important for visibility and monitoring..editorconfig.