Allow running integration tests with coverage locally #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levkk
approved these changes
Aug 30, 2022
There was a problem hiding this comment.
I'm not a fan of local Docker development overall. It doesn't work on everyone's system & it's also very slow. I think we should have two tiers of tests at least:
- Quick and easy tests to make sure the pooler is working ok that run locally with no Docker.
- End-to-end tests that catch any complex errors - we can run that in CircleCI.
|
Agree that it is slow but the feedback loop for CI is much slower, I want to have the option to be able to run the tests I run on CI locally or at least the setup same environment so I can debug CI failures when they happen. |
jmeagher
pushed a commit
to jmeagher/pgcat
that referenced
this pull request
Feb 17, 2023
Exit with failure codes if configs are bad (postgresml#146) Move autoreloader to own tokio task (postgresml#148) Ruby integration tests (postgresml#147) Allow running integration tests with coverage locally (postgresml#151) Log Address information in connection create/drop (postgresml#154) Better handling for checkout errors during extended protocol messages (postgresml#155)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow running integration tests with coverage locally.