Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secrets: New UI panel for Secrets #2252

Closed
Tracked by #2260
mmarchetti opened this issue Sep 4, 2024 · 2 comments · Fixed by #2288
Closed
Tracked by #2260

Secrets: New UI panel for Secrets #2252

mmarchetti opened this issue Sep 4, 2024 · 2 comments · Fixed by #2288
Assignees
Labels
Milestone

Comments

@mmarchetti
Copy link
Collaborator

Create a new collapsible panel at the same level as Python packages, R Packages, etc. It shows the list of secrets from the configuration, with an indicator showing whether each one has been loaded in the current session.

@mmarchetti mmarchetti mentioned this issue Sep 4, 2024
10 tasks
@jonkeane
Copy link
Collaborator

jonkeane commented Sep 5, 2024

with an indicator showing whether each one has been loaded in the current session.

I'm not sure I follow what you mean by this, could you expand a bit more? Loaded to where? What session?

@mmarchetti
Copy link
Collaborator Author

The data flow for secrets in the initial implementation is:

  • they live in a .env file (we exclude .env files from the deployment file list by default, to avoid accidentally sending them)
  • when the user loads them via the extension UI, the UI now holds the secrets
  • the UI sends the secrets with the request to initiate the deployment
  • when the deployment succeeds, or the user changes the UI state to a different deployment, the UI clears the currently loaded secrets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants