Update Sentence.cpp

[muntheralnaeeme]

No description provided.

[porrey]

Is this change correcting a bug or is it for a specific GPS device?

[muntheralnaeeme]

Hi... correcting a bug Thx في الجمعة، ٤ كانون الأول، ٢٠٢٠ ٣:٠١ ص Daniel Porrey < notifications@github.com> كتب:

…

Is this change correcting a bug or is it for a specific GPS device? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AR7UG5YNJB3FXBTROG6JBCDSTARGPANCNFSM4UMOOUTA> .

[porrey]

Thank you. Can you provide more details. What is the bug? What steps can be taken to reproduce it? What is the GPS unit you are using? Provides as much detail as possible.

[muntheralnaeeme]

Hi I use the neo-6m i GPS and upon implementation the results for longitude and latitude are shown in this format 3344. 5678 while it should appear in 33.44 format, and this affects the correct location. Thank you في الجمعة، ٤ كانون الأول، ٢٠٢٠ ٤:٢٦ ص Daniel Porrey < notifications@github.com> كتب:

…

Thank you. Can you provide more details. What is the bug? What steps can be taken to reproduce it? What is the GPS unit you are using? Provides as much detail as possible. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AR7UG54O62FPITG4OEQAGFTSTA3EFANCNFSM4UMOOUTA> .

[ScruffR]

@muntheralnaeeme, I don't think that's correct.
The current implementation is correct and your "fix" would break it as it assumes that the decimal point is only in the wrong place, where in fact you are looking at the NMEA standard which encodes it like this [-]DDDMM.mmmmm (DDD full degrees, MM minutes 0..59, and mmmmm fractional minutes.

A way to convert from this format to decimal degrees could look like this

double decDegFromDMMmm(const char* coord) { // coord as DDDMM.mmmmmm
  int32_t iDeg = atol(coord) / 100;         // full degrees
  double  dMin = atof(coord) - 100*iDeg;    // decimal minutes
  return iDeg + dMin / 60.0;
}

And it would be nice to have such a conversion function added to the library @porrey 😉

[porrey]

I agree. I will add this conversion to library. Thanks!

[muntheralnaeeme]

Thank you! في الجمعة، ٤ كانون الأول، ٢٠٢٠ ٨:٥٠ م Daniel Porrey < notifications@github.com> كتب:

…

I agree. I will add this conversion to library. Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AR7UG5ZMMCULH3WAHNWWQLDSTEOOBANCNFSM4UMOOUTA> .

[muntheralnaeeme]

Sorry, where do I add this conversion? With all due respect, sir

…

On Fri, Dec 4, 2020 at 4:45 PM ScruffR ***@***.***> wrote: @muntheralnaeeme <https://github.com/muntheralnaeeme>, I don't think that's correct. The current implementation is correct and your "fix" would make it incorrect as it assumes that the decimal point is in the wrong place, where in fact you are looking at the NMEA standard which encodes it like this [-]DDDMM.mmmmm (DDD full degrees, MM minutes 0..59, and mmmmm fractional minutes. A way to convert from this format to decimal degrees could look like this double decDegFromDMMmm(const char* coord) { // coord as DDDMM.mmmmmm int iDDMM = atol(coord); // get integer part DDDMM int iDeg = iDDMM / 100; // full degrees int iMin = iDDMM % 100; // full minutes double dMin = atof(coord) - iDDMM; // fractional minutes return iDeg + (iMin / 60.0) + (dMin / 100.0); } And it would be nice to have such a conversion function added to the library. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AR7UG56OCVYLPP4RZR4KIXDSTDRV7ANCNFSM4UMOOUTA> .

[ScruffR]

@muntheralnaeeme, as long it's not part of the library itself, you can put it in your own application code and convert the longitude/latitude strings returned from the library to double
e.g.

  double lon = 0;
  double lat = 0;
  Rmc rmc(gps);
  if (rmc.parse()) {
    lat = decDegFromDMMmm(rmc.latitude);
    lon = decDegFromDMMmm(rmc.longitude);
  }

[muntheralnaeeme]

Thank you!

…

On Fri, Dec 4, 2020 at 11:52 PM ScruffR ***@***.***> wrote: @muntheralnaeeme <https://github.com/muntheralnaeeme>, as long it's not part of the library itself, you can put it in your own application code and convert the longitude/latitude strings returned from the library to double e.g. double lon = 0; double lat = 0; Rmc rmc(gps); if (rmc.parse()) { lat = decDegFromDMMmm(rmc.latitude); lon = decDegFromDMMmm(rmc.longitude); } — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AR7UG55WIZGFDZ3DPSLUGEDSTFDZ3ANCNFSM4UMOOUTA> .

[muntheralnaeeme]

Hi, is there a special gsm sim800l particle photon library. Thank you very match في الجمعة، ٤ كانون الأول، ٢٠٢٠ ١١:٥٩ م munther mohamed < muntheralnaeeme@gmail.com> كتب:

…

Thank you! On Fri, Dec 4, 2020 at 11:52 PM ScruffR ***@***.***> wrote: > @muntheralnaeeme <https://github.com/muntheralnaeeme>, as long it's not > part of the library itself, you can put it in your own application code and > convert the longitude/latitude strings returned from the library to > double > e.g. > > double lon = 0; > double lat = 0; > Rmc rmc(gps); > if (rmc.parse()) { > lat = decDegFromDMMmm(rmc.latitude); > lon = decDegFromDMMmm(rmc.longitude); > } > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#3 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AR7UG55WIZGFDZ3DPSLUGEDSTFDZ3ANCNFSM4UMOOUTA> > . >

[ScruffR]

A question like this should better be posted at community.particle.io

However, I don't think there is one.