Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI allows to specify invalid era period #10737

Closed
1 of 4 tasks
Moliholy opened this issue Jul 8, 2024 · 1 comment · Fixed by #10862
Closed
1 of 4 tasks

GUI allows to specify invalid era period #10737

Moliholy opened this issue Jul 8, 2024 · 1 comment · Fixed by #10862

Comments

@Moliholy
Copy link
Contributor

Moliholy commented Jul 8, 2024

  • I'm submitting a ...
  • Bug report
  • Feature request
  • Support request
  • Other
  • What is the current behavior and expected behavior?

Currently the GUI allows to specify any arbitrary number for the era when signing an extrinsic. However, the maximum period is defined in the runtime, and it is usually 4096 blocks.

Screenshot 2024-07-08 at 16 16 18
  • What is the motivation for changing the behavior?

This can lead users to sign extrinsics with an era that will yield an InValidSignature error, which is not intuitive. At least a warning should be shown to notify the user of this possible behaviour.

@polkadot-js-bot
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants