RewardShare for CI stabilization #1589
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests to verify compatibility will come with a subsequent patch.
The existing `nodes stake` command is not very user-friendly for the following reasons: - Need to specify a subcommand custodial or non-custodial - Need to specify `isBefore8.0` parameter - Unclear about which wallet signs a message It's time to introduce a new stake command that is aligned with the latest node structure.
msmania
force-pushed
the
tokikuch/Built-in-Reward-Share-staging
branch
2 times, most recently
from
564c130
to
f38cd32
Compare
This patch fixes the following tests: - TestValidators_String - TestDefaultParams/Default_Test - TestValidateGenesis/Test_ValidateGenesis_8 This test expected a failure in validation because `GetParams` returned 50 for `MinSignedPerWindow`, but that bug was fixed. The expected result is a success now. and disabled `TestRPC_QueryUnconfirmedTxs` that was flaky. It passed on a local environment, but sometimes failed on GitHub CI.
msmania
force-pushed
the
tokikuch/Built-in-Reward-Share-staging
branch
from
f38cd32
to
82aca5f
Compare
|
All merged with #1581. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to stabilize CI workflow.