Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tendermint version #1541

Merged
merged 3 commits into from
May 25, 2023
Merged

Update tendermint version #1541

merged 3 commits into from
May 25, 2023

Conversation

Olshansk
Copy link
Member

@Olshansk Olshansk commented Apr 5, 2023

Update the tendermint fork version.

Testing

Validated use LocalNet instructions at doc/guides/localnet.md

Changes

@Olshansk Olshansk added bug Something isn't working enhancement New feature or request qol Quality of Life Enhancements labels Apr 5, 2023
@Olshansk Olshansk added this to the Network Quality of Life milestone Apr 5, 2023
@Olshansk Olshansk requested a review from msmania April 5, 2023 22:14
@Olshansk Olshansk self-assigned this Apr 5, 2023
@reviewpad
Copy link

reviewpad bot commented Apr 5, 2023

AI-Generated Pull Request Summary: This pull request updates the Tendermint version in the pokt-network/pocket-core project by modifying the go.mod and go.sum files. The Tendermint version is changed from v0.32.11-0.20220824215059-3214a152d8d4 to v0.32.11-0.20230405220629-96c095f0058d.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Apr 5, 2023
@reviewpad
Copy link

reviewpad bot commented Apr 6, 2023

AI-Generated Summary: This pull request updates the tendermint version dependency in the go.mod file, changing it from v0.32.11-0.20220824215059-3214a152d8d4 to v0.32.11-0.20230405220629-96c095f0058d.

msmania
msmania previously approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@msmania msmania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed on localnet. Looks good!

I can see your struggle on go.mod stuff in the tendermint's commit history :)

@Olshansk
Copy link
Member Author

Olshansk commented Apr 7, 2023

I can see your struggle on go.mod stuff in the tendermint's commit history :)

Haha, yea... Not a fun thing but not something we'll need to worry about in v1.

I'm actually going to hold of on merging this one in until @aqt01 launches a few nodes on TestNet to see how a heterogeneous (w.r.t to Tendermint) network behaves.

Screenshot 2023-04-07 at 10 56 56 AM

@fredteumer
Copy link
Contributor

@Olshansk

is this going to be deployed on mainnet or testnet?

also do you want the node to be spun from no state/genesis or from an existing state?

@Olshansk
Copy link
Member Author

@Olshansk
is this going to be deployed on mainnet or testnet?
also do you want the node to be spun from no state/genesis or from an existing state?

tl;dr I'm going to merge this into main and tag the commit as beta. We, as PNI, should deploy it on MainNet both from genesis and from the latest snapshot you have.

--- Extra optional details ---

@fredteumer This has already been deployed on both TestNet and MainNet per the updates in the Tendermint testing in the release guide.

@aqt01 and @StevenMartinez94 are maintaining it on TestNet

@msmania are deploying it on MainNet

The conversation is ongoing in the public discord channel here.

@Olshansk Olshansk requested a review from fredteumer May 25, 2023 21:29
@Olshansk
Copy link
Member Author

We've been tracking progress of this branch for several days on mainnet & testnet now so will merge this into main.

https://www.notion.so/pocketnetwork/Testing-Tendermint-fbcd3abbed5b4d1ea470a964e2e8b014?pvs=4

@Olshansk Olshansk merged commit 9893696 into staging May 25, 2023
@Olshansk Olshansk deleted the update_tendermint branch May 25, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msmania msmania msmania left review comments

@fredteumer fredteumer Awaiting requested review from fredteumer

Assignees

@Olshansk Olshansk

Labels
bug Something isn't working enhancement New feature or request qol Quality of Life Enhancements small Pull request is small waiting-for-review
Projects
V0 Dashboard
Status: Done
Milestone
Network Quality of Life
Development

Successfully merging this pull request may close these issues.
3 participants
@Olshansk @fredteumer @msmania