Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Document] Improve documentation for pocket nodes #1521

Merged
merged 1 commit into from
Feb 3, 2023
Merged

[Document] Improve documentation for pocket nodes #1521

merged 1 commit into from
Feb 3, 2023

Conversation

Olshansk
Copy link
Member

@Olshansk Olshansk commented Feb 3, 2023

Description

Improved the documentation to clarify the difference of the Operator and Output address

Changes

Before:

Screenshot 2023-02-02 at 5 36 23 PM

After:

Screenshot 2023-02-02 at 5 36 05 PM

Tested with

go build -o pocket app/cmd/pocket_core/main.go
./pocket nodes

@Olshansk Olshansk self-assigned this Feb 3, 2023
jessicadaugherty
jessicadaugherty approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@jessicadaugherty jessicadaugherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Olshansk Olshansk merged commit d0d232b into staging Feb 3, 2023
@Olshansk Olshansk deleted the pocket_nodes_documentation branch February 3, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessicadaugherty jessicadaugherty jessicadaugherty approved these changes

@ArtSabintsev ArtSabintsev Awaiting requested review from ArtSabintsev

Assignees

@Olshansk Olshansk

Labels
documentation
Projects
V0 Dashboard
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Olshansk @jessicadaugherty