Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ServerApplication): termination callback #4643 #4733

Merged
merged 3 commits into from
Oct 15, 2024
Merged

feat(ServerApplication): termination callback #4643 #4733

merged 3 commits into from
Oct 15, 2024

Conversation

aleks-f
Copy link
Member

@aleks-f aleks-f commented Oct 14, 2024

No description provided.

@aleks-f aleks-f requested a review from matejk October 14, 2024 11:13
matejk
matejk approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@matejk matejk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments to consider.

Util/include/Poco/Util/ServerApplication.h Show resolved Hide resolved
Util/include/Poco/Util/ServerApplication.h Outdated Show resolved Hide resolved
@aleks-f aleks-f merged commit f0a2948 into main Oct 15, 2024
44 checks passed
@aleks-f aleks-f deleted the 4643-server-application-callback branch October 15, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejk matejk matejk approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aleks-f @matejk