-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PocoDoc: search support #4494
Open
vrabac6
wants to merge
10
commits into
pocoproject:main
Choose a base branch
from
vrabac6:devel
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
PocoDoc: search support #4494
+339
−207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleks-f
requested changes
Mar 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Windows CI is failing; this needs update of vs90 project and regeneration of 160 and 170 projects
D:\a\poco\poco\PocoDoc\src\DocWriter.cpp(29,10): error C1083: Cannot open include file: 'Poco/Data/Session.h': No such file or directory [D:\a\poco\poco\PocoDoc\PocoDoc_vs170.vcxproj] Error: Final attempt failed. Child_process exited with error code 1```
- to prevent sanitizer CI failures, either pick these changes or simply merge
devel
branch - search support should be a runtime option
- there should be a command line parameter added to
PocoDoc
to generate searchable SQLite DB - obviously, a precondition is SQLite built with FTS support
- there should be a way to check at runtime if
Data/SQLite
supportsFTS
; only if it does can searchable content be produced (otherwise runtime error if searchable cmd line param was give)
- there should be a command line parameter added to
aleks-f
requested changes
Sep 12, 2024
aleks-f
requested changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- this PR is from
devel
branch, which was retired 6 months ago;pocoproject/main
branch needs to be merged here before this PR is merged - FTS5 is available only on Android API Level > 24; see with @zaleksandar if this makes it worth keeping the FTS3/4 support alongside FTS5
Overall consolidation of the FTS capabilities is needed (this should probably be a separate issue):
- there are discrepancies/inaccuracies in the build systems:
- no need for
=<path>
here - this looks like mixing incompatible defines (probably the second one has no effect)
- apparently, VS projects have FTS3 define hardcoded; on Windows FTS5 should be hardcoded in the projects (regenerated from SQLite.progen, not edited directly)
- SQLite test has hardcoded FTS3
- CMake build system should be adjusted to be in accordance with make build, coordinate with @matejk
- no need for
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PocoDoc did not support integration with FTS5 SQLite database for the purpose of inputting clean content into the database. To enhance its functionality, the following improvements have been implemented:
writeDescription
method by adding an output stream containing clean content.writeSearchIndex
, responsible for retrieving textual documentation along with links. This method is called within existing methodswriteClass
,writePackage
, andwriteNameSpace