Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sharedMemory): x64 size error #2976 #4295

Merged
merged 8 commits into from
Nov 26, 2023
Merged

fix(sharedMemory): x64 size error #2976 #4295

merged 8 commits into from
Nov 26, 2023

Conversation

aleks-f
Copy link
Member

@aleks-f aleks-f commented Nov 25, 2023

No description provided.

if (rc == 0) return result;
if (rc == 0)
{
if (keepWaiting(start, remainingTime)) continue;

Check warning

Code scanning / CodeQL

Continue statement that does not continue Warning

This 'continue' never re-runs the loop - the
loop condition
is always false.
remainingTime -= waited;
continue;
}
if (keepWaiting(start, remainingTime)) continue;

Check warning

Code scanning / CodeQL

Continue statement that does not continue Warning

This 'continue' never re-runs the loop - the
loop condition
is always false.
Foundation/src/Task.cpp Dismissed Show dismissed Hide dismissed
@aleks-f aleks-f merged commit 11de403 into devel Nov 26, 2023
18 checks passed
@aleks-f aleks-f deleted the 2976-shm-size-win branch November 26, 2023 03:57
aleks-f added a commit that referenced this pull request Nov 27, 2023
* fix(sharedMemory): x64 size error #2976

* chore: add Util dependency to Prometheus samples

* fix(HTTPClientSession): not working with UNIX_LOCAL SocketAddress #2578

* fix(WebSocketTest): supress connection reset exception assertion

* fix(PollSet): wait on premature epoll_wait return; reinforce tests for windows

* fix(build): add DataTest dependency to Makefile

* fix(Task): intermittently hanging test and some other improvements

* fix(Net): PollSet loop; suppress test WebSocket handler shutdown IOExeption
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant