Replace C string literals (const char*) with C++ std::string literals for std::string parameters.

[obiltschnig]

This should save a lot of std::string constructor calls when passing literal string values to functions expecting std::string.

[Smurf-IV]

And / or maybe use const std::string& ??

[aleks-f]

@obiltschnig put this in Foundation.h?

#include <string>
using namespace std::literals;

Should be ok

[obiltschnig]

I would never put a using namespace declaration in a header. I only put this in .cpp files, or if needed in the header, directly in the function where I need it.

If the core guidelines say it's okay, we may do it, but it still feels kind of dirty to put it in the one header that's included everywhere.

[obiltschnig]

Maybe putting the using namespace std::string_literals; in the Poco namespace may be a better way.

[aleks-f]

Maybe putting the using namespace std::string_literals; in the Poco namespace may be a better way.

In Foundation.h?

[obiltschnig]

Yes

[obiltschnig]

Probably a few more places (e.g. in Data) where this could be done, but will close for now.