fix(JSON): explicitly instantiate and export SharedPtr for JSON::Arra…

…y and JSON::Object (-fvisibility=hidden) (#4393, #3331)
pocoproject · Jan 13, 2024 · fc65f91 · fc65f91
1 parent 77b520f
commit fc65f91
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 0 deletions.
diff --git a/JSON/include/Poco/JSON/Array.h b/JSON/include/Poco/JSON/Array.h
@@ -26,8 +26,17 @@
 
 
 namespace Poco {
+
 namespace JSON {
 
+class JSON_API Array;
+
+}
+
+// Explicitly instantiated shared pointer in JSON library
+extern template class JSON_API Poco::SharedPtr<Poco::JSON::Array>;
+
+namespace JSON {
 
 class Object;
 

diff --git a/JSON/include/Poco/JSON/Object.h b/JSON/include/Poco/JSON/Object.h
@@ -34,8 +34,17 @@
 
 
 namespace Poco {
+
 namespace JSON {
 
+class JSON_API Object;
+
+}
+
+// Explicitly instatiated shared pointer in JSON library
+extern template class JSON_API Poco::SharedPtr<Poco::JSON::Object>;
+
+namespace JSON {
 
 class JSON_API Object
 	/// Represents a JSON object. Object provides a representation based on

diff --git a/JSON/src/Array.cpp b/JSON/src/Array.cpp
@@ -20,6 +20,10 @@
 
 using Poco::Dynamic::Var;
 
+// Explicitly instatiated shared pointer in JSON library is required to
+// have known instance of the pointer to be used with VarHolder when
+// compiling with -fvisibility=hidden
+template class Poco::SharedPtr<Poco::JSON::Array>;
 
 namespace Poco {
 namespace JSON {

diff --git a/JSON/src/Object.cpp b/JSON/src/Object.cpp
@@ -19,8 +19,13 @@
 
 using Poco::Dynamic::Var;
 
+// Explicitly instatiated shared pointer in JSON library is required to
+// have known instance of the pointer to be used with VarHolder when
+// compiling with -fvisibility=hidden
+template class Poco::SharedPtr<Poco::JSON::Object>;
 
 namespace Poco {
+
 namespace JSON {