fix(UUID): UUID parser silently ignores too long strings #4375 (#4384)

pocoproject · Jan 5, 2024 · 67c1a8a · 67c1a8a
1 parent a9d0989
commit 67c1a8a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/Foundation/src/UUID.cpp b/Foundation/src/UUID.cpp
@@ -134,7 +134,7 @@ bool UUID::tryParse(const std::string& uuid)
 	bool haveHyphens = false;
 	if (uuid[8] == '-' && uuid[13] == '-' && uuid[18] == '-' && uuid[23] == '-')
 	{
-		if (uuid.size() >= 36)
+		if (uuid.size() == 36)
 			haveHyphens = true;
 		else
 			return false;

diff --git a/Foundation/testsuite/src/UUIDTest.cpp b/Foundation/testsuite/src/UUIDTest.cpp
@@ -92,6 +92,15 @@ void UUIDTest::testParse()
 	catch (Poco::SyntaxException&)
 	{
 	}
+
+	try
+	{
+		uuid.parse("495cff3a-a4b3-11ee-9e54-9cb6d0f68b51AA");
+		fail("invalid UUID - must throw");
+	}
+	catch (Poco::SyntaxException&)
+	{
+	}
 }